Skip to content

Security Fix: Path Traversal Vulnerability in logs_parsing.go (Alert #474) #9294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jan 8, 2026
Merged

Security Fix: Path Traversal Vulnerability in logs_parsing.go (Alert #474) #9294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77dd243
Security Fix: Path traversal vulnerability in logs_parsing.go (alert …
github-actions[bot] Jan 8, 2026
127bdd3
Merge branch 'main' into main-294cc84d23c86179
pelikhan Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/cli/logs_parsing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,14 @@ var logsParsingLog = logger.New("cli:logs_parsing")
// parseAwInfo reads and parses aw_info.json file, returning the parsed data
// Handles cases where aw_info.json is a file or a directory containing the actual file
func parseAwInfo(infoFilePath string, verbose bool) (*AwInfo, error) {
logsParsingLog.Printf("Parsing aw_info.json from: %s", infoFilePath)
// Sanitize the path to prevent path traversal attacks
cleanPath := filepath.Clean(infoFilePath)
logsParsingLog.Printf("Parsing aw_info.json from: %s", cleanPath)
var data []byte
var err error

// Check if the path exists and determine if it's a file or directory
stat, statErr := os.Stat(infoFilePath)
stat, statErr := os.Stat(cleanPath)
if statErr != nil {
logsParsingLog.Printf("Failed to stat aw_info.json: %v", statErr)
if verbose {
Expand All @@ -47,14 +49,14 @@ func parseAwInfo(infoFilePath string, verbose bool) (*AwInfo, error) {

if stat.IsDir() {
// It's a directory - look for nested aw_info.json
nestedPath := filepath.Join(infoFilePath, "aw_info.json")
nestedPath := filepath.Join(cleanPath, "aw_info.json")
if verbose {
fmt.Fprintln(os.Stderr, console.FormatInfoMessage(fmt.Sprintf("aw_info.json is a directory, trying nested file: %s", nestedPath)))
}
data, err = os.ReadFile(nestedPath)
} else {
// It's a regular file
data, err = os.ReadFile(infoFilePath)
data, err = os.ReadFile(cleanPath)
}

if err != nil {
Expand Down
Loading