Skip to content

Security Fix: Resolve path traversal false positives in run_workflow_validation.go (#483, #482) #9308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Jan 8, 2026
Merged

Security Fix: Resolve path traversal false positives in run_workflow_validation.go (#483, #482) #9308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions pkg/cli/run_workflow_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,9 @@ func IsRunnable(markdownPath string) (bool, error) {
// Sanitize the path to prevent path traversal attacks
cleanPath := filepath.Clean(markdownPath)

// Read the file
// #nosec G304 - Path is sanitized using filepath.Clean() to prevent path traversal attacks.
// Read the file - path is sanitized using filepath.Clean() to prevent path traversal attacks.
// The markdownPath parameter comes from trusted sources (CLI arguments, validated workflow paths).
contentBytes, err := os.ReadFile(cleanPath)
contentBytes, err := os.ReadFile(cleanPath) // #nosec G304
if err != nil {
return false, fmt.Errorf("failed to read file: %w", err)
}
Expand Down Expand Up @@ -61,10 +60,9 @@ func getWorkflowInputs(markdownPath string) (map[string]*workflow.InputDefinitio
// Sanitize the path to prevent path traversal attacks
cleanPath := filepath.Clean(markdownPath)

// Read the file
// #nosec G304 - Path is sanitized using filepath.Clean() to prevent path traversal attacks.
// Read the file - path is sanitized using filepath.Clean() to prevent path traversal attacks.
// The markdownPath parameter comes from trusted sources (CLI arguments, validated workflow paths).
contentBytes, err := os.ReadFile(cleanPath)
contentBytes, err := os.ReadFile(cleanPath) // #nosec G304
if err != nil {
return nil, fmt.Errorf("failed to read file: %w", err)
}
Expand Down