Configurable posixGroup membership filter support #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This blows up for some LDAP servers that don't understand the memberUid filter term.
Now we conditionally add the memberUid filter into the membership check when posixGroup support is enabled only (the default).
mtodd
added a commit
that referenced
this pull request
Aug 21, 2014
…id-support Configurable posixGroup membership filter support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some LDAP servers don't handle unknown attribute filter conditions gracefully (should I be surprised?), let's extract the posixGroup membership filter and conditionally apply it.
This branch enables it by default, but provides a
posix_supportconfiguration flag that can be set tofalseto disable its use.This also largely changes
member_filterback to its previous implementation, keeping theentryparameter in place of thednparameter.