Check memberships recursively #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ran github-ldap/test/group_test.rb Line 20 in 5baa88a Net::LDAP. So that was preventing recursion.
|
Member
Author
There was a problem hiding this comment.
Skips trying PosixGroup unless it's enabled. It's on by default, so this doesn't result in changed behavior, just means we can disable this behavior at will.
Contributor
|
This looks like a trivial and well-tested change that we need so merging. |
MikeMcQuaid
added a commit
that referenced
this pull request
Aug 28, 2014
Check memberships recursively
MikeMcQuaid
added a commit
that referenced
this pull request
Aug 28, 2014
So we can release #40 in a new GitHub Enterprise release.
MikeMcQuaid
added a commit
that referenced
this pull request
Aug 28, 2014
Because #40 warrants a new release by itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we're not properly handling recursive group membership checks. Opening this PR with a failing test to set the state for a fix.