Skip to content

Add group objectclass to allow AD nested group search. #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtodd merged 2 commits into from
Sep 2, 2014
Merged

Add group objectclass to allow AD nested group search. #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b8ac0a
Add group objectclass to allow AD nested group search.
buckelij Sep 1, 2014
c5f5b12
Test group detection for supported object classes
mtodd Sep 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion github-ldap.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Gem::Specification.new do |spec|
spec.name = "github-ldap"
spec.version = "1.3.4"
spec.version = "1.3.5"
spec.authors = ["David Calavera"]
spec.email = ["david.calavera@gmail.com"]
spec.description = %q{Ldap authentication for humans}
Expand Down
2 changes: 1 addition & 1 deletion lib/github/ldap/group.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class Ldap
class Group
include Filter

GROUP_CLASS_NAMES = %w(groupOfNames groupOfUniqueNames posixGroup)
GROUP_CLASS_NAMES = %w(groupOfNames groupOfUniqueNames posixGroup group)

attr_reader :ldap, :entry

Expand Down
4 changes: 4 additions & 0 deletions test/group_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ def setup
end

def test_group?
assert @group.group?(%w(group))
assert @group.group?(%w(groupOfUniqueNames))
assert @group.group?(%w(posixGroup))

object_classes = %w(groupOfNames)
assert @group.group?(object_classes)
assert @group.group?(object_classes.map(&:downcase))
Expand Down