-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Consolidate pull request review tools #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
338e243 to
3b4eaf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR consolidates multiple pull request review tools into a single unified tool. The purpose is to simplify the API by combining separate tools for creating, submitting, and deleting pull request reviews into one tool that uses a method parameter to determine the operation.
- Replaced four separate tools (
CreateAndSubmitPullRequestReview,CreatePendingPullRequestReview,SubmitPendingPullRequestReview,DeletePendingPullRequestReview) with one unifiedPullRequestReviewWritetool - Updated tests to use the new consolidated tool with method-based operation selection
- Updated documentation and instructions to reflect the new unified approach
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Removed old tool registrations and added new unified tool |
| pkg/github/pullrequests.go | Consolidated multiple tool functions into one with method dispatch |
| pkg/github/pullrequests_test.go | Updated tests to use new tool name and method parameter |
| pkg/github/instructions.go | Updated workflow instructions for new tool usage |
| pkg/github/toolsnaps/*.snap | Updated/removed snapshots for tool definitions |
| README.md | Updated documentation to reflect consolidated tool |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
de51fd6 to
f978539
Compare
…to consolidate-prs-write
* Consolidate pull request review tools * Prompt tweaks + deleting snap * Server instructions change * Add enums * Remove excessive mentions of event parameter * Doc update
Consolidating pull request review write tools.
create_and_submit_pull_request_reviewcreate_pending_pull_request_reviewsubmit_pending_pull_request_reviewdelete_pending_pull_request_revieware consolidated under
pull_request_review_writewith method parameter:
createsubmit_pendingdelete_pendingCreateAndSubmit and CreatePending merged under
createmethod as they differ only by 2 parameters -eventandbody.UPD: validated on curated datasets, no regressions accross models.