Fix resource handler to use deps from context#1777
Merged
SamMorrowDrums merged 3 commits intomainfrom Jan 12, 2026
Merged
Conversation
The RepositoryResourceContentsHandler was using closure-captured deps instead of retrieving them from context at call time. This causes issues on the remote server which injects per-request deps via context. Changed to use MustDepsFromContext(ctx) pattern consistent with tool handlers in NewTool and NewToolFromHandler.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the RepositoryResourceContentsHandler to retrieve dependencies from context at call time instead of using closure-captured dependencies. This change enables the remote server to inject per-request dependencies via context, aligning resource handlers with the existing pattern used by tool handlers.
Key Changes:
- Modified
RepositoryResourceContentsHandlerto useMustDepsFromContext(ctx)instead of acceptingdepsas a parameter - Updated
repositoryResourceContentsHandlerFuncto ignore thedepsparameter and call the simplified handler - Updated all test cases to inject dependencies via
ContextWithDepsbefore handler invocation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/repository_resource.go | Changed handler to retrieve deps from context using MustDepsFromContext(ctx), removed deps parameter from function signature, updated doc comment |
| pkg/github/repository_resource_test.go | Updated test setup to inject deps via ContextWithDeps, changed handler function signatures to remove deps parameter, passed context to handler calls |
mattdholloway
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RepositoryResourceContentsHandlerwas using closure-captured deps instead of retrieving them from context at call time. This causes issues on the remote server which injects per-request deps via context.Changes
RepositoryResourceContentsHandlerto useMustDepsFromContext(ctx)pattern consistent with tool handlers inNewToolandNewToolFromHandlerdepsparameter from function signature (now only takesresourceURITemplate)ContextWithDepsbefore calling the handlerTesting