chore: remove unused github.com/fatih/color#1875
Closed
alexandear wants to merge 2 commits intogithub:mainfrom
Closed
chore: remove unused github.com/fatih/color#1875alexandear wants to merge 2 commits intogithub:mainfrom
alexandear wants to merge 2 commits intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused github.com/fatih/color dependency and improves CI validation by enforcing clean module files.
Changes:
- Removed unused
github.com/fatih/colordependency and its transitive dependencies (mattn/go-colorable, mattn/go-isatty) - Updated CI workflow to validate module file cleanliness with
go mod tidy -diffinstead of just downloading dependencies
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Removed github.com/fatih/color from require block and reflowed indirect dependencies alphabetically |
| go.sum | Removed checksums for fatih/color, mattn/go-colorable, mattn/go-isatty, and related golang.org/x/sys entries |
| .github/workflows/go.yml | Changed CI step from go mod download to go mod tidy -diff to enforce module file discipline |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
go.mod:14
- According to the project's coding guidelines, when dependencies are changed, you should run
script/licensesto update the third-party license files. Please verify thatscript/licenseshas been run and commit any changes to the third-party-licenses.*.md files if they were updated. This ensures license compliance is maintained.
go 1.24.0
require (
github.com/google/go-github/v79 v79.0.0
github.com/google/jsonschema-go v0.4.2
github.com/josephburnett/jd v1.9.2
github.com/microcosm-cc/bluemonday v1.0.27
github.com/muesli/cache2go v0.0.0-20221011235721-518229cd8021
github.com/spf13/cobra v1.10.2
github.com/spf13/viper v1.21.0
github.com/stretchr/testify v1.11.1
)
SamMorrowDrums
approved these changes
Jan 26, 2026
Collaborator
SamMorrowDrums
left a comment
There was a problem hiding this comment.
Thanks, great catch! Appreciate the diligent PRs.
Collaborator
|
Closing in favor of #1892 which rebases your commits onto main. Your authorship has been preserved - thank you for the contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
github.com/fatih/colordependency.Why
The
fatih/colorpackage was unused in the codebase. This can be detected viago mod tidy. To prevent future regressions, this step was added in place ofgo mod download. Additionally, a workaround is needed on Windows to handle CRLF line endings that causego mod tidy -diffto fail during CI runs.What changed
github.com/fatih/colorfromgo.modandgo.sumfatih/colorgo mod downloadtogo mod tidy -difffor better dependency validationMCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goLint & tests
./script/lint./script/testDocs