Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a naming inconsistency by renaming InsiderMode to InsidersMode throughout the codebase to align with the actual feature name "insiders mode" and its associated environment variable GITHUB_INSIDERS_MODE and flag --insiders-mode.
Changes:
- Renamed the
InsiderModefield toInsidersModein theFeatureFlagsstruct and all configuration structs - Updated all references from
insider-modetoinsiders-modein flags, viper bindings, and test helpers - Updated documentation in README.md and docs/remote-server.md to reflect the corrected naming
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/feature_flags.go | Renamed struct field from InsiderMode to InsidersMode |
| pkg/github/server_test.go | Updated test helper to use insiders-mode key |
| pkg/github/feature_flags_test.go | Updated test code and variable names to use InsidersMode |
| internal/ghmcp/server.go | Updated struct fields, comments, and usage of InsidersMode in both MCPServerConfig and StdioServerConfig |
| internal/ghmcp/server_test.go | Updated test configuration to use InsidersMode |
| cmd/github-mcp-server/main.go | Updated CLI flag from --insider-mode to --insiders-mode and all viper bindings |
| README.md | Updated documentation examples to use --insiders-mode flag and GITHUB_INSIDERS_MODE environment variable |
| docs/remote-server.md | Updated documentation reference from GITHUB_INSIDER_MODE to GITHUB_INSIDERS_MODE and --insider-mode to --insiders-mode |
SamMorrowDrums
approved these changes
Jan 26, 2026
This was referenced Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Alignment of names
What changed
MCP impact
Prompts tested (tool changes only)
Security / limits
Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs