Add in Custom Backgrounds and update Readme.md#19
Open
thelonewolf39 wants to merge 13 commits intogithub:mainfrom
Open
Add in Custom Backgrounds and update Readme.md#19thelonewolf39 wants to merge 13 commits intogithub:mainfrom
thelonewolf39 wants to merge 13 commits intogithub:mainfrom
Conversation
…er_4KUHD_16_9.webp
Added background selection functionality and updated layout.
Added a contributors section to acknowledge contributors.
Damovisa
reviewed
Nov 9, 2025
Damovisa
requested changes
Nov 9, 2025
Collaborator
Damovisa
left a comment
Damovisa
left a comment
There was a problem hiding this comment.
The custom upload works great until the download when it doesn't get rendered. Can you have a look at the download as well?
Author
I have just fixed that bug, please let me know if more come up! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project looks really cool, but I did see 1 change that could be made: Custom Backgrounds! I added in 2 backgrounds that your wonderful team made in your github blogs, then allowed custom background uploading! I also added in a section into Readme.md that lists all contributors to give them attribution for everything they've done :)
@Damovisa
@jldeen