Conversation
I actually ran into this on #27 as well. I'd love to avoid manually setting an excerpt for each page, but we may need to. @benbalter @parkr if you have time, I'd love your thoughts on the best way to handle this. |
|
@bkeepers Can we use collection documents instead of pages here? Collection documents give you automatic excerpts (same code as blog posts). |
|
@parkr if you could point me to some docs about collection documents I can make the change (sorry, first time Jekyll user). |
|
@parkr it looks like it's this: https://jekyllrb.com/docs/collections/#using-collections |
| @@ -1,4 +1,6 @@ | |||
| title: "Open Source Handbook" | |||
| url: http://opensource.guide | |||
There was a problem hiding this comment.
If you don't do this, it should use site.github.url, which could account for things like HTTPS (in the works for GitHub-owned domains).
|
I've started on a conversion to collections here: https://github.com/github/open-source-handbook/tree/kytrinyx-collections The basic site structure appears to be ok, but I haven't figured out the navigation yet. |
|
Oh, and I bet the linting etc doesn't work with it yet. |
|
@kytrinyx We could pair on it if you want! Each folder just prefixes with an underscore ( collections:
- docs
- marketingIf you want to change the permalink, you can specify metadata: collections:
docs:
output: true
permalink: /lol/:title
marketing:
output: true:) |
|
@parkr Yes! I'd love to pair on it. |
|
(I tried that approach and got a bunch of 404s, btw) |
|
Here's what I have working: For the linter: I have no idea how to translate the navigation: I can't just swap out |
|
OK, I think I got this working. Thanks @benbalter and @parkr for patient handholding. PR in #132. |
|
Closing this one. The most important thing we needed were meta descriptions, which was addressed in #132. Everything else was nice-to-haves/maybe-not-even-necessarys :) Thanks everyone for your help! |
Applies to #122
Page excerptDone in Use a collection instead of pages for the articles #132It appears the page excerpt part is going to be problematic. Jekyll extracts an excerpt automatically and this is what the jekyll-seo-tag gem relies on. The problem seems to be that Jekyll only extracts that excerpt on blog posts. Since all of the content in this site are normal pages, it isn't constructing the excerpt.