Skip to content

[WIP] Design!#198

Merged
sophshep merged 43 commits intogh-pagesfrom
design
Feb 11, 2017
Merged

[WIP] Design!#198
sophshep merged 43 commits intogh-pagesfrom
design

Conversation

@sophshep
Copy link

@sophshep sophshep commented Feb 3, 2017

This PR starts to add some design to the guide 🎉

So far, I have:

  • Taken out all the legacy CSS and updated with the latest Primer
  • Roughed out the homepage layout so it's ready for art
  • Styled the typography on the guide pages to match mockups
  • Added tables of contents drop downs
    • Note: These have to be added manually in the YAML front matter, since they are part of the title rather than the content - I checked with Parker and there's nothing we can do about this. A bit annoying but not too bad.

Still to do:

  • Incorporate @jeejkang's beautiful artwork
  • Style the footer
  • Fancy blockquote styles
  • Vignette styles

Questions/notes for @nayafia & @bkeepers

  • Will we have a working search?
  • What content would you like in the footer? (Currently it's a contact email and a sign up form for subscribing to updates)
  • Some of the guides have a lead in paragraph before the first section starts. Is it possible to work those into the first section instead? Otherwise the design gets a bit wonky (example).

👓 Sneak Preview of work in progress:

image

image

@zeke
Copy link

zeke commented Feb 3, 2017

👏 Love the progress so far.

@nayafia
Copy link
Contributor

nayafia commented Feb 3, 2017

Hooray, design!

Will we have a working search?

I'll let @bkeepers answer this one. My guess is no, but he hasn't yet closed out #27

What content would you like in the footer? (Currently it's a contact email and a sign up form for subscribing to updates)

Let's do "subscribe to updates" (as it is), and

# Contribute
Want to make a suggestion? This content is open source. [Help us improve it](https://github.com/github/open-source-guide/).

as an inline link, or

# Contribute
Want to make a suggestion? This content is open source. Help us improve it.
[Contribute](https://github.com/github/open-source-guide/)

^ if a button style looks better

No contact email needed.

Some of the guides have a lead in paragraph before the first section starts. Is it possible to work those into the first section instead? Otherwise the design gets a bit wonky (example).

Yep! I'll do that in a separate PR.

@nayafia nayafia mentioned this pull request Feb 3, 2017
@bkeepers bkeepers mentioned this pull request Feb 6, 2017
7 tasks
@sophshep sophshep merged commit d1c2092 into gh-pages Feb 11, 2017
@sophshep sophshep deleted the design branch February 11, 2017 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments