This repository was archived by the owner on Oct 20, 2023. It is now read-only.
Add serial connection Flow control for Intel's UartSub devices in Windows#2
Open
iderzhav wants to merge 1 commit intogithub:masterfrom
Open
Add serial connection Flow control for Intel's UartSub devices in Windows#2iderzhav wants to merge 1 commit intogithub:masterfrom
iderzhav wants to merge 1 commit intogithub:masterfrom
Conversation
…onnection settings in Windows In order to initiate serial connection with Intel's UartSub Devices: ACPI\INT3511 and ACPI\INT3512 following DCB struct fields should be set: fDtrControl = DTR_CONTROL_DISABLE fRtsControl = RTS_CONTROL_DISABLE Added "Disable DTR/RTS" option to Flow control list box of serial connection settings which add desired functionality to putty.exe Signed-off-by: Igor Derzhavets <igor.derzhavets@compulab.co.il>
Contributor
|
Hi Igor @iderzhav You are submitting request to GitHub mirror of PuTTY repository. I'm not sure if it is monitored by PuTTY's maintainer Simon Tatham, so I advise to approach him directly (e-mail: putty at projects.tartarus.org) |
Author
Hello, |
rtsp
pushed a commit
to rtsp7/putty
that referenced
this pull request
Sep 7, 2021
When do_paint breaks up a line of terminal text into contiguous runs of characters to treat the same, one of the criteria it uses is, 'Does this character even need redrawing? (or is it already displayed correctly from the previous redraw?)' When we encounter a character that matches its previous value, we end the previous run of characters, so that we can skip the one we've just encountered. That check was not taking account of the 'truecolour' field of the termchar it was checking. So it would sometimes falsely believe the character to be equivalent to its previously drawn value, even when in fact it was not, and hence insert a run break, anticipating that the previous character needed drawing and the current one did not. This didn't cause a _wrong_ redraw, because there's a separate loop further on which re-checks whether to actually draw things, which didn't make the same error. So the character that loop github#1 thought didn't need a redraw, loop github#2 knew _did_ need a redraw, and hence, everything did get redrawn. But by the time loop github#2 is running, it's too late to change the run boundaries. So everything does get redrawn, but in much smaller chunks than it could have been. The net effect was that if the screen was filled with text displayed in true colour, and you changed it to the _same_ text in a different colour, then the whole terminal would be redrawn in one-character increments instead of the usual behaviour of folding together runs that can be drawn in one go. Thanks to Bradley Smith for debugging this very confusing issue!
rtsp
pushed a commit
to rtsp7/putty
that referenced
this pull request
Dec 28, 2021
Now, we always try an initial CONNECT request with no auth at all, and wait for the proxy to reject it before sending a second try with auth. That way, we can wait to see what _kind_ of authentication the proxy requests, which will enable us to support something more secure than Basic, such as HTTP Digest. (I mean, it would _work_ to try Basic in request github#1 and then retrying with Digest in github#2 when the proxy asks for it. But if the aim of using Digest is to avoid sending the password in cleartext, it defeats the entire purpose to have sent it in cleartext anyway by the time you realise the server is prepared to do something better!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to initiate serial connection with Intel's UartSub Devices:
ACPI\INT3511 and ACPI\INT3512 following DCB struct fields should be set:
fDtrControl = DTR_CONTROL_DISABLE
fRtsControl = RTS_CONTROL_DISABLE
Added "Disable DTR/RTS" option to Flow control list box of serial
connection settings which add desired functionality to putty.exe
Signed-off-by: Igor Derzhavets igor.derzhavets@compulab.co.il