Fix for the bug where all the repo override files are not read #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: safe-settings use get-content api to fetch all the repo permission override files. That api has a limit of 1000 and our org had way > 1000 repo files in the admin repo. This has lead to incorrect repo permissions. GitHub Api docs: https://docs.github.com/en/rest/repos/contents?apiVersion=2022-11-28#get-repository-content Fix is to use the github tree api(https://docs.github.com/en/rest/git/trees?apiVersion=2022-11-28#get-a-tree) to read all the repos directory content.
Author
|
@decyjphr Please take a look at this when you get some time. Thanks! |
decyjphr
reviewed
Jan 28, 2023
|
|
||
| // read the repo contents using tree | ||
| this.log.debug(`repos directory info ${JSON.stringify(repoDirInfo)}`) | ||
| const endpoint = `/repos/${this.repo.owner}/${repo.repo}/git/trees/${repoDirInfo.sha}` |
Collaborator
There was a problem hiding this comment.
One option would be to replace github.request with some syntactic sugar github.git.getTree({owner, repo, tree_sha}) https://octokit.github.io/rest.js/v18#git-get-tree
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
safe-settings use get-content api to fetch all the repo permission override files. That api has a limit of 1000 and our org had way > 1000 repo files in the admin repo. This has lead to incorrect repo permissions.
GitHub Api docs: https://docs.github.com/en/rest/repos/contents?apiVersion=2022-11-28#get-repository-content
Fix is to use the github tree api(https://docs.github.com/en/rest/git/trees?apiVersion=2022-11-28#get-a-tree) to read all the repos directory content.