Skip to content

Conversation

@randomcascade
Copy link
Contributor

@randomcascade randomcascade commented Sep 24, 2024

Fixes: #551 Would love if someone else could validate the testing as I'm not sure I've tested every case.

@luvsaxena1
Copy link
Contributor

@decyjphr Another contribution from my company, We noticed this is an issue which people does not noticed and it impact environments.

@klutchell
Copy link
Contributor

Any objection to this one @decyjphr ? I would love to see it merged.

@randomcascade
Copy link
Contributor Author

It looks like plugins have received an update to include an errors parameter so this plugin may not be 100% in line, if that's a problem I can update it sometime in the next week or so.

@randomcascade
Copy link
Contributor Author

Merge conflicts resolved. Ready to merge if possible.

@decyjphr
Copy link
Collaborator

Thanks @randomcascade will look into merging this soon.

@decyjphr decyjphr requested a review from Copilot January 19, 2025 21:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@decyjphr decyjphr merged commit 3b7eb05 into github:main-enterprise Jan 19, 2025
2 checks passed
@klutchell
Copy link
Contributor

Is this working for you @randomcascade ? We are still seeing environment changes being applied to production for unmerged PRs. We also don't see proposed environment changes in the dry-run comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nop on PRs doesn't work for environments

4 participants