Java: Timing attacks while comparing results of cryptographic operations #378
Description
Query
Relevant PR: github/codeql#6006
CVE ID(s)
The query detects a few known CVEs:
Report
A constant time algorithm should be used when comparing results of cryptographic operations such as hashes, MACs, signatures and ciphertexts. In other words, the comparison time should not depends on the content of the inputs. Otherwise, an attacker may be able to implement a timing attacks that may reveal sensitive information.
I'd like to propose a new experimental query that looks for data flows from cryptographic operations to methods that compare arrays or strings using a not-constant time algorithm.
- Are you planning to discuss this vulnerability submission publicly? (Blog Post, social networks, etc). We would love to have you spread the word about the good work you are doing
Update: I've written a blog post about the query and timing attacks.
Result(s)
- CVE-2017-3156 in Apache CXF 3.1.9
- CVE-2019-10071 in Apache Tapestry 5.4.4