Skip to content

Conversation

@btoews
Copy link
Contributor

@btoews btoews commented Feb 21, 2019

Same as #7, but for Certificates. The changes are mostly about cleaning up the code in Encoding and abstracting tests a bit.

@btoews btoews requested a review from ptoomey3 February 21, 2019 23:28
@btoews
Copy link
Contributor Author

btoews commented Feb 21, 2019

For context, the main motivation here is that the OpenSSH version running on Janky boxes doesn't allow for arbitrary certificate extensions. This should get https://github.com/github/github/pull/108335 passing and clean up the test fixtures on that branch.

@btoews
Copy link
Contributor Author

btoews commented Feb 21, 2019

I take that back. This isn't quite ready for review. I want to add the ability to sign a cert.

@btoews
Copy link
Contributor Author

btoews commented Feb 22, 2019

Okay. This is ready for 👀 now. For what it's worth, I'm not too concerned with this code, given that it is only going to be used in tests.

Copy link
Member

@ptoomey3 ptoomey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be frank, I've only given this a cursory review. There are a lot of additions here that I'm not terribly familiar with. If you think it is worth the time to set aside for a deeper review 👍, just let me know and I will. But, if you think it isn't terribly security-critical (as you noted, the main use case here is for test) and that the tests are good enough to have pretty strong confidence, then I'm ok with that as well.

@btoews btoews merged commit f07d827 into master Feb 25, 2019
@btoews btoews deleted the re-encode-certs branch February 25, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants