The UX is broken with v2.3.0 of @github/combobox-nav dependency

[StanBright]

A quick report that v2.3.0 of @github/combobox-nav and the new scrollIntoView broke the UX of @github/text-expander for me. It would push the expanded <ul> to the top of the screen. Also, when I scroll down with the keyboard over the available options (<li> elements), it would try to move the highlighted element to the top of the screen. After spending a few hours debugging what's the core of the issue, I noticed that the undesirable UX happens after the combobox-nav dependency of text-expander is upgraded to v2.3.0.

I think this is the PR that's bugging the behaviour github/combobox-nav#75

If someone else is facing this issue, my solution was to fix combobox-nav to v2.2.0 through "resolutions" section of package.json.

[keithamus]

Would you kindly provide a reduced test case and we can look into it.

[wxiaoguang]

Here is the sample for the bug:

• Emoji and mention autocomplete shift the view go-gitea/gitea#28595

[wxiaoguang]

It should use "nearest" behavior IMO.

[keithamus]

If you want to raise a PR with the default to nearest I'd happily merge and release, and hopefully it resolves the issue.

[wxiaoguang]

Use "nearest" behavior for scrollIntoView github/combobox-nav#79

Does it look good to you? Feel free to edit it directly or replace it. Thank you.

[keithamus]

https://github.com/github/combobox-nav/releases/tag/v2.3.1