[DO NOT MERGE] PR shoving output of clang-tidy in typical case

[atsju]

what would it show in #263

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v18.1.3) reports: 1 concern(s)

• surfacemanager.cpp:2799:5: warning: [clang-analyzer-cplusplus.NewDeleteLeaks]

  Potential leak of memory pointed to by 'plot'

   2799 |     painter.end();
        |     ^
  surfacemanager.cpp:2744:9: note: Assuming the condition is false
   2744 |     if (!dlg.exec()) {
        |         ^~~~~~~~~~~
  surfacemanager.cpp:2744:5: note: Taking false branch
   2744 |     if (!dlg.exec()) {
        |     ^
  surfacemanager.cpp:2749:24: note: Memory is allocated
   2749 |     ContourPlot *plot =new ContourPlot(0,0);//m_contourPlot; //TODO leaking ? 
        |                        ^~~~~~~~~~~~~~~~~~~~
  surfacemanager.cpp:2761:5: note: Loop condition is false. Execution continues on line 2762
   2761 |     qDebug() << "save all" << imageRect;
        |     ^
  /usr/include/x86_64-linux-gnu/qt6/QtCore/qlogging.h:151:18: note: expanded from macro 'qDebug'
    151 | #  define qDebug QT_NO_QDEBUG_MACRO
        |                  ^
  /usr/include/x86_64-linux-gnu/qt6/QtCore/qlogging.h:147:28: note: expanded from macro 'QT_NO_QDEBUG_MACRO'
    147 | #define QT_NO_QDEBUG_MACRO while (false) QMessageLogger().noDebug
        |                            ^
  surfacemanager.cpp:2766:9: note: Assuming field 'm_do_fill' is false
   2766 |     if (plot->m_do_fill) {
        |         ^~~~~~~~~~~~~~~
  surfacemanager.cpp:2766:5: note: Taking false branch
   2766 |     if (plot->m_do_fill) {
        |     ^
  surfacemanager.cpp:2773:21: note: Assuming the condition is false
   2773 |     for (int i = 0; i < list.size(); ++i)
        |                     ^~~~~~~~~~~~~~~
  surfacemanager.cpp:2773:5: note: Loop condition is false. Execution continues on line 2799
   2773 |     for (int i = 0; i < list.size(); ++i)
        |     ^
  surfacemanager.cpp:2799:5: note: Potential leak of memory pointed to by 'plot'
   2799 |     painter.end();
        |     ^

Have any feedback or feature suggestions? Share it here.

[github-actions]

🚀 New build available for commit c263477
Download installer here

[atsju]

OK here we are. Only one warning by clang-tidy on my PR.
Even better: it's 100% relevant. I was concerned by line 2749 ContourPlot *plot =new ContourPlot(0,0);//m_contourPlot; //TODO leaking ? and wrote the comment before looking at clang-tidy outputs.

I recommend merging #296 (not this one) as it should not be too noisy and still makes good review.

as I explained there is a very tiny bit of warning leaking on unmodified code: #296 (comment)

point 3: About half of the clang comments were on code that you hadn't modified. It seems maybe it was either all code in the modified file or it was code near the edits. I'm not sure which.

What it does basically is a diff. If it shows in diff then it's reviewed. If you look again you will see most comments are on modified code (even if modification is only a space change on this line).
Very few are indeed on unmodified code but very near. This is from how diff works.
I confirm the whole file is not reviewed. This has been tested and verified.