Skip to content

fix: empty model name passes validation (chars().all() on empty iterator) #178

@jamesadevine

Description

@jamesadevine

Problem

generate_copilot_params validates the model name with chars().all(...), but chars().all() returns true for an empty iterator. EngineConfig::Simple("") would produce --model (trailing space, no value).

Low-severity since a blank model string is unlikely in practice, but the empty check was missing.

Fix Applied

Added model.is_empty() guard before the character validation.

Fixed in #175.

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingsecurity

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions