test: add regression test for branch name single-quote escaping in pipeline triggers

[Copilot]

generate_pipeline_resources escapes embedded single quotes in branch names (' → ''), but the only existing escaping test (test_pipeline_resources_escapes_single_quotes) only asserted on source: and project: — leaving the branch escaping path completely uncovered.

Changes

• src/compile/common.rs — extends test_pipeline_resources_escapes_single_quotes to include a branch with an embedded single quote and asserts the correct YAML output:

branches: vec!["main".to_string(), "it's-branch".to_string()],
// ...
assert!(result.contains("- 'it''s-branch'"));

[jamesadevine]

/rust-review

[github-actions]

✅ Rust PR Reviewer completed successfully!

[github-actions]

🔍 Rust PR Review

Summary: Looks good — a clean, well-targeted regression test.

Findings

✅ What Looks Good

• Correctness: The assertion assert!(result.contains("- 'it''s-branch'")) precisely mirrors the escaping logic on line 309 of common.rs (branch.replace('\'', "''") wrapped in single-quote delimiters). Verified manually and confirmed by running the test locally — passes cleanly.
• Scope: The PR does exactly what it says. One changed file, three lines touched, no production code modified.
• Coverage gap closed: The previous test only checked source: and project: escaping. Branch name escaping was a real blind spot — if someone ever changed the branch formatting code, nothing would have caught the regression. This fills it.
• Test style is consistent with the existing test_pipeline_resources_escapes_single_quotes pattern (same function, same assertion style).

No bugs, security concerns, or suggestions. Ready to merge.

Generated by Rust PR Reviewer for issue #183 · ● 491K · ◷