Skip to content

Conversation

@manosim
Copy link
Member

@manosim manosim commented Dec 7, 2015

Closes #32 and #111.

Cross Testing:

  • OSX
  • Windows 10 (all taskbar positions: bottom, top, left and right)
  • Linux Mint XFCE (top and bottom)
  • Linux Manjaro XFCE (bottom, top, left and right)
  • Ubuntu 14LTS (requires libappindicator1, but works)

Windows Release:

  • Check Autoupdate (.zip or .exe?)
  • Check Autostart
  • App Icon (.ico)

Linux Release:

  • Remove autoupdate button from settings
  • Check Autostart
  • App Icon (?)

Help Wanted

The app should work fine now on OSX, Windows and some Linux distributions. It would be great if any folks can help with testing. Basically just running the app to see what works and what's broken in different platforms. We do have a private channel in the atom slack team (http://atom-slack.herokuapp.com/) so if you are interested in testing, ping me on Slack in the atom team (username: ekonstantinidis).

@manosim manosim changed the title Support Windows & Linux - Remove menubar Support Windows & Linux Dec 7, 2015
@manosim manosim added the help-wanted Extra attention is needed label Dec 7, 2015
@manosim manosim added this to the Release 0.0.19 milestone Dec 7, 2015
@mrmlnc
Copy link
Contributor

mrmlnc commented Dec 10, 2015

Autolaunch works with Windows.

Emmanouil Konstantinidis added 2 commits December 14, 2015 15:17
@manosim manosim removed this from the Release 0.0.19 milestone Jan 6, 2016
Emmanouil Konstantinidis added 2 commits May 5, 2016 23:07
# Conflicts:
#	Gruntfile.js
#	main.js
#	package.json
@TheInitializer
Copy link

GNOME pls? <3

@manosim manosim mentioned this pull request May 29, 2016
@Serkan-devel
Copy link

Will there be lxde or lxqt support for this?

@brpaz
Copy link

brpaz commented Nov 26, 2016

Whats the status of this PR?
I can help with Linux version if needed.

@Serkan-devel
Copy link

Any updates on this?
I'd recommend Appimage as package

@Viper007Bond Viper007Bond mentioned this pull request Dec 1, 2017
@edubxb
Copy link

edubxb commented Feb 16, 2018

Linux support would be awesome! thanks for the effort!

Copy link

@danielstclair danielstclair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'm going to test it on Manjaro and let you know how it goes.

@probonopd
Copy link

probonopd commented Apr 1, 2018

Please ping me once the AppImage is available so that I can include it on https://appimage.github.io/apps/.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add #dashboard of issues insights

@jimmed
Copy link

jimmed commented Aug 23, 2018

What is the status of this issue? I just built the latest from the cross-gitify branch on Ubuntu 18.04, and I'm getting arbitrary JS errors when booting:

A JavaScript error occurred in the main process
Uncaught Exception:
TypeError: Cannot read property '0' of null
    at Object.<anonymous> (/home/jim/dev/bucket/gitify/Gitify-linux-x64/resources/app.asar/main.js:22:43)
    at Object.<anonymous> (/home/jim/dev/bucket/gitify/Gitify-linux-x64/resources/app.asar/main.js:215:3)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Object.<anonymous> (/home/jim/dev/bucket/gitify/Gitify-linux-x64/resources/electron.asar/browser/init.js:171:8)
    at Object.<anonymous> (/home/jim/dev/bucket/gitify/Gitify-linux-x64/resources/electron.asar/browser/init.js:173:3)
    at Module._compile (module.js:571:32)

Unsure if this is me having missed some critical build step, or this is the result of incompatibility.

Edit: I figured this out myself ─ the code that initialises AutoStart depends on the Gitify being launched as an OSX .app. I can raise a PR to workaround later if required.

@manosim manosim mentioned this pull request Apr 5, 2020
@manosim manosim closed this in #396 Apr 5, 2020
@manosim manosim deleted the cross-gitify branch April 5, 2020 20:25
@manosim
Copy link
Member Author

manosim commented Apr 5, 2020

It's been a really long time since this PR was opened but I've finally got some time to sort this out in v3. Unless any bugs pop up, the next version will have support for both Windows & Linux. 🎉

@OskarKlintrot
Copy link

On https://www.gitify.io/ I can see that there is a download-button for Windows but nothing happens when I try to click on it. Is it supposed to be working yet? :)

@manosim
Copy link
Member Author

manosim commented Apr 15, 2020

Planning to release support for both Windows & Linux this week (this button was on a hurry to go live on the website 😂)

In the meantime - you can download a pre-release from this link.

@JakeSidSmith
Copy link
Contributor

I cannot access this link...

@manosim
Copy link
Member Author

manosim commented Apr 15, 2020

Any chance that GitHub allows you to download the artifacts from GitHub Actions? I've made it so that it builds the app for every commit and stores the app as an artifact.
https://github.com/manosim/gitify/actions/runs/71310056

@JakeSidSmith
Copy link
Contributor

Oooh, looks like it. I'll hopefully give that a go tomorrow. 👍

@probonopd
Copy link

There is no AppImage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help-wanted Extra attention is needed

Development

Successfully merging this pull request may close these issues.

Any plans for linux (ubuntu) support?