fix: use thread subscription set endpoint #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I used the new unsubscribe feature, I discovered an annoying little idiosyncrasy - the set thread subscription endpoint encompasses more thorough functionality than the delete thread subscription endpoint.
Essentially - both endpoints can mute all future notifications for a conversation until you comment on the thread or get an @mention. However, the delete endpoint includes this caveat:
Which sort of nerfs a lot of the reasons one would unsubscribe from a notification in the first place. To unsubscribe regardless of watch status, one should actually hit the set thread subscription endpoint with a PUT call and pass
ignore: truein the call body, which is what this PR does.cc @manosim