Skip to content

Conversation

@codebytere
Copy link
Collaborator

@codebytere codebytere commented Jun 19, 2020

Closes #417.

When gitify first opens, it will now request to move itself to the Applications folder on macOS. The user's choice will be stored for subsequent runs. If it's already in the Applications folder, no prompts are shown.

cc @manosim I pulled the functionality into a new file but if you'd prefer I can put it into main.js or do something else entirely with it, up to you!

Copy link
Member

@manosim manosim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @codebytere 🎉

I think we will have to include first-run.js in electron-builder's configuration as currently, it won't be included when packaging (yarn make:macos). By the way, does this support/ignore Windows & Linux?

I agree with pulling that functionality to a separate file - one for the future - if we get more files like that, it might be worth pulling in a separate directory?

@codebytere
Copy link
Collaborator Author

@manosim yes - it skips if we're not on darwin. app.moveToApplicationsFolder is macOS-only but this is primarily in that other platforms are less opinionated about application location and/or handle it at the system level, so there's not really a cross-platform expectation for this type of user pattern there I wouldn't say.

@codebytere codebytere force-pushed the move-to-applications-folder branch from 4931706 to 3be8999 Compare June 21, 2020 16:30
@codebytere codebytere requested a review from manosim June 23, 2020 17:32
@manosim manosim merged commit d0ca1a0 into gitify-app:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Move to applications folder functionality on macOS

2 participants