Skip to content

chore: upgrade to Electron v9 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manosim merged 2 commits into from
Jun 23, 2020
Merged

chore: upgrade to Electron v9 #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
076e52f
chore: upgrade to Electron v9
codebytere Jun 19, 2020
2e9d2c1
Update yarn lockfile
codebytere Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
"electron-updater": "^4.2.5",
"final-form": "^4.19.1",
"lodash": "^4.17.15",
"menubar": "^8.0.1",
"menubar": "^9.0.1",
"nprogress": "=0.2.0",
"react": "=16.13.1",
"react-dom": "=16.13.1",
Expand Down Expand Up @@ -141,7 +141,7 @@
"@types/react-redux": "^7.1.7",
"@types/react-transition-group": "^4.2.4",
"@types/styled-components": "^5.0.1",
"electron": "^8.2.0",
"electron": "^9.0.0",
"electron-builder": "^22.4.1",
"electron-notarize": "^0.3.0",
"jest": "^25.2.7",
Expand Down
3 changes: 1 addition & 2 deletions src/js/components/ui/checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ const StyledCheckbox = styled.div`
}

${Icon} {
// @ts-ignore
visibility: ${(props) => (props.isChecked ? 'visible' : 'hidden')};
visibility: ${(props) => ((props as any).isChecked ? 'visible' : 'hidden')};
}
`;

Expand Down
14 changes: 7 additions & 7 deletions src/js/routes/__snapshots__/settings.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
>
Settings
</h3>
<button
<a
aria-label="Close Settings"
className="sc-fzoLsD cUlvxj"
onClick={[Function]}
>
×
</button>
</a>
</div>
<div
className="sc-Axmtr fLAtpJ"
Expand All @@ -39,7 +39,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
type="checkbox"
/>
<div
className="sc-AxhUy VqymF"
className="sc-AxhUy juIZhB"
>
<svg
className="sc-AxiKw bCXYxk"
Expand Down Expand Up @@ -93,7 +93,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
type="checkbox"
/>
<div
className="sc-AxhUy fPqOA-d"
className="sc-AxhUy gbfYbF"
>
<svg
className="sc-AxiKw bCXYxk"
Expand Down Expand Up @@ -147,7 +147,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
type="checkbox"
/>
<div
className="sc-AxhUy fPqOA-d"
className="sc-AxhUy gbfYbF"
>
<svg
className="sc-AxiKw bCXYxk"
Expand Down Expand Up @@ -201,7 +201,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
type="checkbox"
/>
<div
className="sc-AxhUy VqymF"
className="sc-AxhUy juIZhB"
>
<svg
className="sc-AxiKw bCXYxk"
Expand Down Expand Up @@ -255,7 +255,7 @@ exports[`routes/settings.tsx should render itself & its children 1`] = `
type="checkbox"
/>
<div
className="sc-AxhUy VqymF"
className="sc-AxhUy juIZhB"
>
<svg
className="sc-AxiKw bCXYxk"
Expand Down
2 changes: 1 addition & 1 deletion src/js/routes/settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const Title = styled.h3`
font-weight: 500;
`;

const ButtonClose = styled.button`
const ButtonClose = styled.a`
border: 0;
padding: 0.25rem;
font-size: 2rem;
Expand Down
Loading