fix: oversized repository lines #462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repository would stretch to fill the entire app viewport. This is because of the flex-1 class in tailwind allowing the flex item to stretch to fill the remaining space. Changing to flex-initial prevents the stretch. This could also be removed entirely but I thought it's best to have something set so we're not relying on electron to set some defaults.
studioromeo
force-pushed
the
bug-fix-repository-oversized
branch
from
0f9806c to
dc97d1b
Compare
Member
|
Hey @studioromeo, thank you so much for opening this PR! Gitify went through a major refactor this week (moved from redux to context etc) so this was fixed as part of that (#463). 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya! 👋
There might be raised in a few places but this relates to #458. I noticed that we moved to tailwind recently so I think this was just a small bug from that refactor.
What I've done here is set the flex of the repository item to
flex-initialwhich is equivalent toflex: 0 1 auto;it lets the items shrink but not grow beyond their size. Hopefully this should do the job, it seems to work fine from my limited testing but you may want to give it a razz too!This is my first contribution here so let me know if you want anything changed, thats no worries 🙂