Skip to content

feat: Add link to GitHub Notifications page #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manosim merged 1 commit into from
Jan 4, 2021
Merged

feat: Add link to GitHub Notifications page #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/components/Sidebar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,27 @@ describe('components/Sidebar.tsx', () => {
expect(pushMock).toHaveBeenCalledTimes(1);
});

it('open the gitify repo in browser', () => {
it('opens github in the notifications page', () => {
const { getByLabelText } = render(
<AppContext.Provider
value={{
isLoggedIn: true,
notifications: mockedAccountNotifications,
}}
>
<MemoryRouter>
<Sidebar />
</MemoryRouter>
</AppContext.Provider>
);
fireEvent.click(getByLabelText('4 Unread Notifications'));
expect(shell.openExternal).toHaveBeenCalledTimes(1);
expect(shell.openExternal).toHaveBeenCalledWith(
'https://github.com/notifications'
);
});

it('opens the gitify repo in browser', () => {
const { getByLabelText } = render(
<AppContext.Provider value={{ isLoggedIn: true, notifications: [] }}>
<MemoryRouter>
Expand All @@ -92,5 +112,8 @@ describe('components/Sidebar.tsx', () => {
);
fireEvent.click(getByLabelText('View project on GitHub'));
expect(shell.openExternal).toHaveBeenCalledTimes(1);
expect(shell.openExternal).toHaveBeenCalledWith(
'https://github.com/manosim/gitify'
);
});
});
10 changes: 9 additions & 1 deletion src/components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ export const Sidebar: React.FC = () => {
shell.openExternal(`https://github.com/${Constants.REPO_SLUG}`);
}, []);

const onOpenGitHubNotifications = useCallback(() => {
shell.openExternal(`https://github.com/notifications`);
}, []);

const quitApp = useCallback(() => {
ipcRenderer.send('app-quit');
}, []);
Expand All @@ -43,7 +47,11 @@ export const Sidebar: React.FC = () => {
/>

{notificationsCount > 0 && (
<div className="flex justify-around self-stretch items-center my-1 py-1 px-2 text-green-500 text-xs font-extrabold">
<div
className="flex justify-around self-stretch items-center my-1 py-1 px-2 text-green-500 text-xs font-extrabold cursor-pointer"
onClick={onOpenGitHubNotifications}
aria-label={`${notificationsCount} Unread Notifications`}
>
<Octicons.BellIcon size={12} />
{notificationsCount}
</div>
Expand Down
8 changes: 6 additions & 2 deletions src/components/__snapshots__/Sidebar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ exports[`components/Sidebar.tsx should render itself & its children (logged in)
</g>
</svg>
<div
className="flex justify-around self-stretch items-center my-1 py-1 px-2 text-green-500 text-xs font-extrabold"
aria-label="4 Unread Notifications"
className="flex justify-around self-stretch items-center my-1 py-1 px-2 text-green-500 text-xs font-extrabold cursor-pointer"
onClick={[Function]}
>
<svg
aria-hidden="true"
Expand Down Expand Up @@ -195,7 +197,9 @@ exports[`components/Sidebar.tsx should render itself & its children (logged out)
</g>
</svg>
<div
className="flex justify-around self-stretch items-center my-1 py-1 px-2 text-green-500 text-xs font-extrabold"
aria-label="4 Unread Notifications"
className="flex justify-around self-stretch items-center my-1 py-1 px-2 text-green-500 text-xs font-extrabold cursor-pointer"
onClick={[Function]}
>
<svg
aria-hidden="true"
Expand Down