chore(refactor): Simplify window re-open #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
This was referenced Oct 4, 2023
Base automatically changed from
10-03-chore_electron_Move_off_deprecated_remote_module
to
main
October 9, 2023 23:37
afonsojramos
approved these changes
Oct 9, 2023
Member
afonsojramos
left a comment
afonsojramos
left a comment
There was a problem hiding this comment.
I suppose that we don't really need to abstract this. LGTM
Member
|
Not sure why this PR is part of the stack though, I assume just out of convenience? |
afonsojramos
approved these changes
Oct 9, 2023
Collaborator
Author
|
Yeah, I think I was just in context and defaulted to adding to the stack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.