Skip to content

refactor: split issue state types and document pullrequest state type #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmulholland merged 3 commits into from
Mar 1, 2024
Merged

refactor: split issue state types and document pullrequest state type #826

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
137f189
refactor: split issue state types and document pullrequest state type
setchy Feb 26, 2024
7887776
Merge remote-tracking branch 'origin/main' into refactor/split-issue-…
setchy Feb 29, 2024
4f3ab2d
Merge branch 'main' into refactor/split-issue-state-types
setchy Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/typesGithub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,20 @@ export type SubjectType =
| 'RepositoryVulnerabilityAlert'
| 'WorkflowRun';

export type IssueStateType =
| 'closed'
| 'completed'
| 'not_planned'
| 'open'
| 'reopened';
export type IssueStateType = 'closed' | 'open';

export type IssueStateReasonType = 'completed' | 'not_planned' | 'reopened';

/**
* Note: draft and merged are not official states in the GitHub API.
* These are derived from the pull request's `merged` and `draft` properties.
*/
export type PullRequestStateType = 'closed' | 'draft' | 'merged' | 'open';

export type StateType =
| DiscussionStateType
| IssueStateType
| IssueStateReasonType
| PullRequestStateType;

export type ViewerSubscription = 'IGNORED' | 'SUBSCRIBED' | 'UNSUBSCRIBED';
Expand Down