Skip to content

refactor(icons): replace add account icon with octicons primer version #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
setchy wants to merge 1 commit into from
Closed

refactor(icons): replace add account icon with octicons primer version #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions src/icons/AddAccount.tsx
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/routes/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { useNavigate } from 'react-router-dom';
import { FieldCheckbox } from '../components/fields/Checkbox';
import { FieldRadioGroup } from '../components/fields/RadioGroup';
import { AppContext } from '../context/App';
import { IconAddAccount } from '../icons/AddAccount';
import { PersonAddIcon } from '@primer/octicons-react';
import { IconLogOut } from '../icons/Logout';
import { IconQuit } from '../icons/Quit';
import { Appearance } from '../types';
Expand Down Expand Up @@ -168,7 +168,7 @@ export const SettingsRoute: React.FC = () => {
aria-label="Login with GitHub Enterprise"
onClick={goToEnterprise}
>
<IconAddAccount className="w-5 h-5" />
<PersonAddIcon size={24} />
</button>

<button
Expand Down
30 changes: 10 additions & 20 deletions src/routes/__snapshots__/Settings.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,28 +293,18 @@ exports[`routes/Settings.tsx should render itself & its children 1`] = `
>
<svg
aria-hidden="true"
aria-labelledby="iconAddAccountId"
class="w-5 h-5"
class="octicon octicon-person-add"
fill="currentColor"
focusable="false"
height="24"
role="img"
viewBox="0 0 640 512"
xmlns="http://www.w3.org/2000/svg"
style="display: inline-block; user-select: none; vertical-align: text-bottom; overflow: visible;"
viewBox="0 0 24 24"
width="24"
>
<title
id="iconAddAccountId"
>
Add Account
</title>
<g>
<path
d="M640 224v32a16 16 0 01-16 16h-64v64a16 16 0 01-16 16h-32a16 16 0 01-16-16v-64h-64a16 16 0 01-16-16v-32a16 16 0 0116-16h64v-64a16 16 0 0116-16h32a16 16 0 0116 16v64h64a16 16 0 0116 16z"
fill="currentColor"
opacity="0.4"
/>
<path
d="M224 256A128 128 0 1096 128a128 128 0 00128 128zm89.6 32h-16.7a174.08 174.08 0 01-145.8 0h-16.7A134.43 134.43 0 000 422.4V464a48 48 0 0048 48h352a48 48 0 0048-48v-41.6A134.43 134.43 0 00313.6 288z"
fill="currentColor"
/>
</g>
<path
d="M4 9.5a5 5 0 1 1 7.916 4.062 7.973 7.973 0 0 1 5.018 7.166.75.75 0 1 1-1.499.044 6.469 6.469 0 0 0-12.932 0 .75.75 0 0 1-1.499-.044 7.972 7.972 0 0 1 5.059-7.181A4.994 4.994 0 0 1 4 9.5ZM9 6a3.5 3.5 0 1 0 0 7 3.5 3.5 0 0 0 0-7Zm10.25-5a.75.75 0 0 1 .75.75V4h2.25a.75.75 0 0 1 0 1.5H20v2.25a.75.75 0 0 1-1.5 0V5.5h-2.25a.75.75 0 0 1 0-1.5h2.25V1.75a.75.75 0 0 1 .75-.75Z"
/>
</svg>
</button>
<button
Expand Down