fix: update mac entitlements to prevent macos crash electron@20+ #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsojramos
approved these changes
Mar 28, 2024
Member
afonsojramos
left a comment
afonsojramos
left a comment
There was a problem hiding this comment.
Just tested locally with the version built in the action and I could not believe my eyes! Let's get this merged already!
Member
Author
Amazing, isn't it. I just lucky to stumble across that example buried within the electron-builder repository, and subtly hinted at on their docs. And like all good engineers, I copy/pasted and prayed for the best 😅 |
Collaborator
|
This is awesome!! Fantastic work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing, these updates to the mac entitlements have been very promising to unblocking our update to electron@29 conundrum