Conversation
Contributor
|
I think we want to keep it to 15 minutes for cloud, but 1 minute for Dedicated. Correct me if I'm wrong @svenefftinge |
mustard-mh
commented
Apr 24, 2024
| { | ||
| cacheTime: 1000 * 60 * 10, // 10 minutes | ||
| staleTime: 1000 * 60 * 10, // 10 minutes | ||
| cacheTime: 1000 * 60 * 1, // 1 minutes |
Contributor
Author
There was a problem hiding this comment.
The reason data is not updated every 15 minutes is because we have dashboard caches, not sure if we do want to remove caches, 1m should be fine for users
mustard-mh
commented
Apr 24, 2024
| } | ||
|
|
||
| spec, err := scheduler.NewResetUsageJob(schedule, jobClientsConstructor) | ||
| func startScheduler(ctx context.Context, cfg Config, redsyncPool *redsync.Redsync, jobClientsConstructor scheduler.ClientsConstructor) { |
Contributor
Author
There was a problem hiding this comment.
We have to stop scheduler and restart again to update cron. Upstream PR robfig/cron#274 to add update method is there opened for 4 years already 🙈.
svenefftinge
approved these changes
Apr 29, 2024
Contributor
Author
|
Thank you @svenefftinge , will double check on dogfood |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add FF
usage_update_scheduler_durationto control repeat duration of usage data update15m, see opsRelated Issue(s)
Fixes EXP-1768
How to test
kubectl logs -f usage-<tab tab> -c usage | code -You could try run script below in DevTool > Terminal to fetch usage data automatically. Don't forget to update your organization ID in
dataUnit tests
Unit tests should pass, see server_test.go, there's a command to exec tests. But tests is flaky because of timing, jobs may exec during each ticker we grab the value. We only need to make sure it can pass one time.
✅ Dashboard test result for 2m
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold