Skip to content

Comments

fix(finish): Use the start point branch when finishing#76

Open
dermojo wants to merge 1 commit intogittower:mainfrom
dermojo:main
Open

fix(finish): Use the start point branch when finishing#76
dermojo wants to merge 1 commit intogittower:mainfrom
dermojo:main

Conversation

@dermojo
Copy link

@dermojo dermojo commented Feb 20, 2026

When finishing a branch, check the (stored) start point used to create the branch. If it differs from the configured start point, merge back to this branch instead. This ensures that e.g. creating releases from another branch works as expected.

Resolves #71
Refs #36

Remarks

  • No tests added yet
  • Docs not updated yet

Review focus:

  • Current tests suggest to me that the changed behavior is NOT intended
  • However, the current test (TestFinishUsesConfiguredParent) still passes and should be adapted
  • I want to start a discussion for this changed behavior nevertheless because I need this fix

When finishing a branch, check the (stored) start point used to create
the branch. If it differs from the configured start point, merge back
to this branch instead. This ensures that e.g. creating releases from
another branch works as expected.

Resolves gittower#71
Refs gittower#36
@dermojo dermojo changed the title fix(finish): Use the start point when finishing fix(finish): Use the start point branch when finishing Feb 20, 2026
@bmcdonnell-fb
Copy link

#71 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating releases from support branches

2 participants