Merge graphics library into main library with untested functions by YuanSang0512 · Pull Request #50 · gkit-org/libgkit

YuanSang0512 · 2026-04-27T06:21:17Z

No description provided.

…not been tested yet.）

CoraBlack

我只审核完 include 目录下的东西，但依旧有很多东西需要更改：

主库中函数方法均使用蛇形命名法
其余注释和代码等风格请参考主库其他代码，库需要统一的代码风格才能支撑维护性

Note

多审阅自己的代码，避免意义不明的改动
多使用git进行小提交，大量的代码更改会让我我无法快速追踪代码的更改内容和理解修改的意义。此外，频繁细小的提交有利于代码回退和追踪，尤其使用AI工具的情况下，这是好的开发习惯

CoraBlack · 2026-04-27T06:39:54Z

应当使用git-lfs追踪二进制资源，避免仓库膨胀和困于解决合并冲突

CoraBlack · 2026-04-27T06:47:59Z

+    - name: Install Python dependencies
+      shell: cmd
      run: |
-        echo "📦 Installing Windows dependencies..."
-
-        echo "✅ Windows dependencies installed successfully"
+        echo "📦 Installing Python dependencies..."
+        C:\hostedtoolcache\windows\Python\3.14.4\x64\python3.exe -m pip install jinja2
+        echo "✅ Python dependencies installed successfully"


hyw？ 为什么要把Windows dependents 改成 Python dependents

不知道，全是claude写的

CoraBlack · 2026-04-27T06:48:40Z

-        echo "Job status: ${{ job.status }}"
-
-        # # List built files
-        # echo "📁 Built files:"
-        # find ${{ github.workspace }}/build -name "*.so" -o -name "*.dll" -o -name "*.a" -o -name "*.lib" 2>/dev/null || echo "No library files found"
-
-        # # Show disk usage
-        # echo "💾 Disk usage:"
-        # du -sh ${{ github.workspace }}/build 2>/dev/null || echo "Build directory size info not available"


CoraBlack · 2026-04-27T07:02:17Z

+		/// @brief Apply all dirty states to OpenGL
+		auto Apply() -> void;


考虑添加 const 修饰

考虑添加 const 修饰

why

CoraBlack · 2026-04-27T07:11:37Z

+		/**
+		* @brief Add an element to the layout (unsupported type - compile-time error)
+		* @tparam T Data type
+		* @param count Number of components
+		*/
+		template<typename T>
+		void Push(uint32_t count)
+		{
+			static_assert(sizeof(T) == 0, "Unsupported type for VertexBufferLayout::Push");
+		}


未完成？

未完成？

没看懂，还缺什么

Copilot

Pull request overview

This PR integrates a new OpenGL-based graphics module into gkit, adds GLAD as a third-party dependency, and introduces a graphics “test” executable plus shader assets to exercise the new rendering path.

Changes:

Add GLAD submodule/build integration and link GLAD/SDL dependencies into the main libraries/tests.
Introduce a new src/graphic module (Renderer, Shader, OpenGL buffer/state wrappers) and corresponding public headers.
Add a test/graphic/test_window.cpp demo plus shader files/resources wiring.

Reviewed changes

Copilot reviewed 32 out of 34 changed files in this pull request and generated 20 comments.

Show a summary per file

File	Description
`third_party/CMakeLists.txt`	Adds GLAD generation/build and exposes generated include dir.
`src/CMakeLists.txt`	Adds `graphic/` subdir and links GLAD to `gkit` libs.
`src/graphic/CMakeLists.txt`	Defines `gkit_graphic` object library with OpenGL sources.
`src/graphic/Renderer.cpp`	Implements basic clear/draw calls via OpenGL.
`src/graphic/Shader.cpp`	Implements shader parsing/compile/link and uniform setters.
`src/graphic/opengl/config.cpp`	Adds viewport helper wrappers around `glViewport`.
`src/graphic/opengl/VertexBuffer.cpp`	Adds VBO wrapper implementation.
`src/graphic/opengl/IndexBuffer.cpp`	Adds IBO wrapper implementation.
`src/graphic/opengl/VertexArray.cpp`	Adds VAO wrapper + instancing attribute setup.
`src/graphic/opengl/Texture.cpp`	Adds texture wrapper skeleton (bind/unbind + lifetime).
`src/graphic/opengl/FrameBuffer.cpp`	Adds FBO wrapper implementation and attachment helpers.
`src/graphic/opengl/RenderBuffer.cpp`	Adds RBO wrapper implementation.
`src/graphic/opengl/StateManager.cpp`	Adds dirty-flag OpenGL state manager implementation.
`include/gkit/graphic/Renderer.hpp`	Public Renderer API.
`include/gkit/graphic/Shader.hpp`	Public Shader API and shader source struct.
`include/gkit/graphic/opengl/config.hpp`	Public OpenGL enums/constants + viewport API.
`include/gkit/graphic/opengl/VertexBuffer.hpp`	Public VBO wrapper.
`include/gkit/graphic/opengl/IndexBuffer.hpp`	Public IBO wrapper.
`include/gkit/graphic/opengl/VertexBufferLayout.hpp`	Public vertex layout helper.
`include/gkit/graphic/opengl/VertexArray.hpp`	Public VAO wrapper.
`include/gkit/graphic/opengl/Texture.hpp`	Public texture wrapper API.
`include/gkit/graphic/opengl/FrameBuffer.hpp`	Public framebuffer wrapper API.
`include/gkit/graphic/opengl/RenderBuffer.hpp`	Public renderbuffer wrapper API.
`include/gkit/graphic/opengl/StateManager.hpp`	Public OpenGL state manager API.
`test/CMakeLists.txt`	Adds `graphic/*.cpp` tests and links SDL/GLAD for test executables.
`test/graphic/test_window.cpp`	Adds interactive SDL/OpenGL window demo using new module.
`test/graphic/basic.shader`	Adds basic shader asset.
`test/graphic/texture.shader`	Adds textured quad shader asset.
`test/graphic/post_process.shader`	Adds post-processing shader asset.
`.gitmodules`	Adds GLAD submodule.
`.gitignore`	Ignores generated GLAD output directory.
`.github/workflows/windows-debug-build-test.yml`	Updates Windows CI steps (Python/Jinja2 install).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-29T03:13:14Z

+glad_add_library(glad_gl STATIC
+    API "gl:core=4.6"
+    REPRODUCIBLE
+    LOCATION "${CMAKE_SOURCE_DIR}/third_party/glad_generated"
+)


glad_add_library(... LOCATION "${CMAKE_SOURCE_DIR}/third_party/glad_generated" ) generates code into the source tree. This breaks read-only source checkouts and leaves untracked/generated files behind after builds. Prefer generating into the build directory (e.g., under ${CMAKE_BINARY_DIR}) and point include dirs at that location, or make the location configurable via a cache variable.

@CoraBlack 怎么说，是否采纳

…lasses

…::VertexArray& va, const gkit::graphic::Shader& shader) const -> void

…rrors.

…Lists target_link_libraries

YuanSang0512 and others added 5 commits April 26, 2026 21:28

Merge the graphics library into the main library（Some functions have …

850ed51

…not been tested yet.）

Merge the graphics library into the main library（Some functions have …

232204b

…not been tested yet.）

fix

708a0ae

Fix Windows workflow

5aa84e0

Merge branch 'gkit-org:main' into feature/merge-render-lib

5f1d9c0

github-project-automation Bot added this to libgkit-dev-record Apr 27, 2026

github-project-automation Bot moved this to Todo in libgkit-dev-record Apr 27, 2026

CoraBlack requested changes Apr 27, 2026

View reviewed changes

Modify the comment format

b6eae64

CoraBlack requested a review from Copilot April 29, 2026 03:04

Copilot started reviewing on behalf of CoraBlack April 29, 2026 03:05 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

YuanSang0512 added 10 commits April 29, 2026 19:33

Change Renderer and StateManager to inherit from singleton template c…

1473be0

…lasses

The VertexBuffer has added the UpdateSubData and UpdateData interfaces.

6f9422f

delete auto gkit::graphic::Renderer::Draw(const gkit::graphic::opengl…

b38b06a

…::VertexArray& va, const gkit::graphic::Shader& shader) const -> void

Disable copy functionality, enable move functionality; fix spelling e…

b8e29e4

…rrors.

Fix the bug in VAO index

c449122

Modify the function naming method

a2e4fe3

Remove the Get method of the Renderer、StateManager

577dfc3

Add shader compilation and linking checks; Access log system

4f9dc33

Fix shader parsing undefined behavior and add validation；Change CMake…

5a526fd

…Lists target_link_libraries

Some minor modifications regarding function naming

5a57f27

		/// @brief Apply all dirty states to OpenGL
		auto Apply() -> void;

Conversation

YuanSang0512 commented Apr 27, 2026

Uh oh!

CoraBlack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants