Add colorBounds param to control colorscale range#5
Merged
Conversation
- update module names - update api call (coords needs to be length 3)
- use to clamp to color scale range, instead of always relying on z-data bounds
2 tasks
Member
There was a problem hiding this comment.
This could be N_COLORS*c[3] if they are meant to always match.
Member
Author
There was a problem hiding this comment.
I don't think they were meant to match.
Replacing 255 with N_COLORS does change the colormap slightly.
Member
|
Sweet, if those things are supposed to be coupled lets put that Constant to use. Otherwise 💃 ! |
etpinard
added a commit
that referenced
this pull request
Jan 4, 2016
Add colorBounds param to control colorscale range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4
More background info in: plotly/plotly.js#86
This PR adds the ability to control the colorscale range with a
colorBoundsparameter.The current behavior where the surface coloring is based only on the min and the max of the field array is kept as the default.