Open
Conversation
gingersnapp
force-pushed
the
sb/update-sample-oms
branch
2 times, most recently
from
61e260a to
2da989f
Compare
gingersnapp
force-pushed
the
sb/update-sample-oms
branch
from
2da989f to
cb7becd
Compare
rnovales
approved these changes
Jul 17, 2025
Collaborator
rnovales
left a comment
rnovales
left a comment
There was a problem hiding this comment.
LGTM
just checking that the intent here was to add the Makefile targets so they are ready to use when customer devs start building, no expectation that validation and tests pass out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.