Skip to content

Fix React Error 185 in ChatView by deferring markThreadVisited#2

Open
gleber wants to merge 1 commit intomainfrom
fix/react-185-chat-view-11849620451264782131
Open

Fix React Error 185 in ChatView by deferring markThreadVisited#2
gleber wants to merge 1 commit intomainfrom
fix/react-185-chat-view-11849620451264782131

Conversation

@gleber
Copy link
Copy Markdown
Owner

@gleber gleber commented Apr 7, 2026

Summary

Fixes React error pingdotgg#185 ("Maximum update depth exceeded") in React 19 caused by synchronous state updates within a single React commit cycle.

Details

In apps/web/src/components/ChatView.tsx, the useEffect that calls markThreadVisited(serverThread.id) was triggering a synchronous Zustand store update. This caused a React re-render, which re-ran the effect and potentially created an infinite update loop.

This PR wraps the markThreadVisited call in startTransition, which tells React to treat the update as non-urgent. This defers the state update out of the synchronous commit cycle, breaking the loop and avoiding the error.


PR created automatically by Jules for task 11849620451264782131 started by @gleber

Wraps `markThreadVisited` in `startTransition` inside `ChatView.tsx` to defer the Zustand update out of React's synchronous commit cycle. This prevents an infinite re-render loop ("Maximum update depth exceeded") in React 19 caused by synchronous state updates from within the `useEffect`.

Co-authored-by: gleber <33185+gleber@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant