Fix React Error 185 in ChatView by deferring markThreadVisited#2
Fix React Error 185 in ChatView by deferring markThreadVisited#2
Conversation
Wraps `markThreadVisited` in `startTransition` inside `ChatView.tsx` to defer the Zustand update out of React's synchronous commit cycle. This prevents an infinite re-render loop ("Maximum update depth exceeded") in React 19 caused by synchronous state updates from within the `useEffect`.
Co-authored-by: gleber <33185+gleber@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Fixes React error pingdotgg#185 ("Maximum update depth exceeded") in React 19 caused by synchronous state updates within a single React commit cycle.
Details
In
apps/web/src/components/ChatView.tsx, theuseEffectthat callsmarkThreadVisited(serverThread.id)was triggering a synchronous Zustand store update. This caused a React re-render, which re-ran the effect and potentially created an infinite update loop.This PR wraps the
markThreadVisitedcall instartTransition, which tells React to treat the update as non-urgent. This defers the state update out of the synchronous commit cycle, breaking the loop and avoiding the error.PR created automatically by Jules for task 11849620451264782131 started by @gleber