Skip to content

Conversation

@sbesson sbesson force-pushed the bf2raw_0.11.0_r2ometiff_0.8.0 branch 2 times, most recently from b60a350 to 1b8e85e Compare September 16, 2025 20:28
Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, as discussed separately. bioformats2raw does have a few new options (--compact and --no-tiles in particular), so before merging I think we should decide on the roadmap for adding those options vs just getting #75 merged and released quickly.

Leaving open for discussion in Wednesday meetings, and then happy to approve/merge once we have a plan.

@sbesson
Copy link
Member Author

sbesson commented Sep 17, 2025

Thanks Melissa. I mostly opened #76 to start the discussion internally but from my side, the priority should be to target a release of NGFF-Converter with #75 included as soon as possible.

In preparation of this discussion, would it be useful to look into the updates to this PR necessary to expose the new API options introduced in bioformats2raw in the graphical interface?

@sbesson sbesson marked this pull request as draft September 19, 2025 15:00
@sbesson sbesson marked this pull request as ready for review September 22, 2025 11:29
@sbesson
Copy link
Member Author

sbesson commented Sep 22, 2025

As discussed on Friday, the last commit now exposes the new conversion options introduced in bioformats2raw to the graphical interface.

Testing-wise, it should be possible to select:

  • Compact dimensions to generate Zarr datasets with dimensionalities XY, XYZ, XYT, XYC, XYZT, XYZC, XYCT (depending on the input dimension)
  • Disable tile writing to generate Zarr datasets with no chunks

@melissalinkert melissalinkert self-requested a review September 22, 2025 13:41
Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff makes sense, and testing with the new Compact dimensions and Disable tile writing options works as expected.

@sbesson sbesson mentioned this pull request Sep 23, 2025
@melissalinkert melissalinkert merged commit a79a4a0 into glencoesoftware:main Sep 23, 2025
3 checks passed
@sbesson sbesson deleted the bf2raw_0.11.0_r2ometiff_0.8.0 branch September 23, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants