-
Notifications
You must be signed in to change notification settings - Fork 8
Bump Bio-Formats, bioformats2raw and raw2ometiff versions #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Bio-Formats, bioformats2raw and raw2ometiff versions #76
Conversation
See * https://github.com/glencoesoftware/bioformats2raw/releases/tag/v0.11.0 * https://github.com/glencoesoftware/bioformats2raw/releases/tag/v0.10.1 * https://github.com/glencoesoftware/bioformats2raw/releases/tag/v0.10.0 * https://github.com/glencoesoftware/bioformats2raw/releases/tag/v0.9.4 * https://github.com/glencoesoftware/raw2ometiff/releases/tag/v0.8.0 and * https://bio-formats.readthedocs.io/en/v8.3.0/about/whats-new.html * https://bio-formats.readthedocs.io/en/v8.2.0/about/whats-new.html * https://bio-formats.readthedocs.io/en/v8.1.1/about/whats-new.html * https://bio-formats.readthedocs.io/en/v8.1.0/about/whats-new.html * https://bio-formats.readthedocs.io/en/v8.0.1/about/whats-new.html * https://bio-formats.readthedocs.io/en/v8.0.0/about/whats-new.html for the list of upstream changes
…lang3 Declare org.apache.commons:commons-lang3 as a direct dependency
b60a350 to
1b8e85e
Compare
melissalinkert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, as discussed separately. bioformats2raw does have a few new options (--compact and --no-tiles in particular), so before merging I think we should decide on the roadmap for adding those options vs just getting #75 merged and released quickly.
Leaving open for discussion in Wednesday meetings, and then happy to approve/merge once we have a plan.
|
Thanks Melissa. I mostly opened #76 to start the discussion internally but from my side, the priority should be to target a release of NGFF-Converter with #75 included as soon as possible. In preparation of this discussion, would it be useful to look into the updates to this PR necessary to expose the new API options introduced in bioformats2raw in the graphical interface? |
|
As discussed on Friday, the last commit now exposes the new conversion options introduced in Testing-wise, it should be possible to select:
|
melissalinkert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff makes sense, and testing with the new Compact dimensions and Disable tile writing options works as expected.
See
and
for the list of upstream changes.
As per the changes in ome/bioformats#4343,
commons-langis no longer a transitive dependency of Bio-Formats. 9f1f9a6 updates the code base tocommons-lang3and declares it as an explicit dependency.