feat(api/ui): api support for showing / hiding the native tab bar#156
Conversation
RobertCraigie
left a comment
There was a problem hiding this comment.
This is so cool!!!!!! Thank you for working on this :)
There was a problem hiding this comment.
I think it'd be slightly better to instead include the .css files directly in the browser build, as updating any of them is as simple as a cp or a curl -o from the firefox-csshacks repository.
That does complicate the internal setters somewhat though as I'm not aware of a synchronous equivalent to ChromeUtils.importESModule() for .css / arbitrary text files.
So if we can't find a builtin way to do that, we'd need to add that internal API somehow, or make the set native_tabs() function asynchronous and use the fetch_resource() helper, which maybe is fine? I'm not sure, it definitely feels weird.
Any thoughts?
There was a problem hiding this comment.
Updating them might not be that simple, since some have multiple use cases and require tweaks depending on what you want to achieve (see autohide for vertical tabs). So there might be a patching step there.
It would ofc be nicer to have the CSS in proper files. Could they be linked to with style tags when bundled in?
From the user perspective I would also feel weird if the "hide some toolbar" option had a micro package manager integrated. 😄
|
Great feedback, tysm! :) |
RobertCraigie
left a comment
There was a problem hiding this comment.
Looks great, thank you! Some minor comments
|
Wait actually it looks like Screen.Recording.2025-12-20.at.8.24.02.pm.movI suspect this is a bug with firefox-csshacks though so... I think we can just document that |
|
Shame, can't have nice things. I'll include a warning. |
01b30fc to
20924d2
Compare
|
I had a last minute realisation that this should really be I pushed an extra commit making that change so you don't have to deal with the thrash :) Unfortunately Thanks again! |
|
Sounds good! Really appreciate the help |
closes #18
Basically just did the things written in the issue.
Chose
hideovertruesince I found some interesting options likeautohidewhen I looked through the CSS hacks.Included the CSS in a separate file, since it is pretty long. I kept the source references which should make it
MPL 2.0compliant.Quick demo:
glide-tabs-demo.mp4
Also included a small description and some sanity tests.
I also have a similar setup for the nav bar / main toolbar, which I did not include but I find very handy (I use librewolf without any bars).
Demo for that:
glide-navbar-demo.mp4