Remove deprecated distutils
#360
Conversation
Replaced usage of distutils.util.strtobool with a custom str_to_bool function in audit.py and health.py for improved clarity and consistency. Updated landing.py to utilize importlib.metadata for package metadata retrieval.
salmanmashayekh
changed the title
distutils
| except DistributionNotFound: | ||
| package_metadata = metadata(graph.metadata.name) | ||
| return package_metadata | ||
| except PackageNotFoundError: |
There was a problem hiding this comment.
Nice @salmanmashayekh looks like almost 1-to-1 replacement
microcosm_flask/converters.py
Outdated
| def str_to_bool(value): | ||
| """ | ||
| Convert a string value to boolean. | ||
| Similar to distutils.util.strtobool but returns a boolean instead of an int. |
There was a problem hiding this comment.
I'm a little worried about the similar to .. but returns a boolean instead of an int - mostly because microcosm-flask is used everywhere and this could have some side-effects that will be tricky to debug / will only show up in a while from now when someone pulls in latest microcosm-flask.
So if you want to go with this I would test thoroughly with at least 1-2 services that it works as expected
adamhadani
left a comment
adamhadani
left a comment
There was a problem hiding this comment.
LGTM but with important comment / caveat on the str_to_bool function and backward compatibility.
|
updated the function to match the return type @adamhadani |
adamhadani
left a comment
adamhadani
left a comment
There was a problem hiding this comment.
LGTM, I would try this out locally with 1-2 services that use it, e.g. by pip install -e . this package into the venv of a service and run it locally
…o types-setuptools now not needed in entrypoint.sh mypy entrypoint
…of that release which fixes remaining failures
| from collections.abc import Mapping | ||
| from functools import lru_cache | ||
| from pkg_resources import iter_entry_points | ||
| from importlib.metadata import entry_points |
There was a problem hiding this comment.
now using importlib instead of pkg_resources, this was last remaining references to this now deprecated package.
| float_to_top = True | ||
| include_trailing_comma = True | ||
| known_first_party = microcosm_flask | ||
| extra_standard_library = pkg_resources |
There was a problem hiding this comment.
no longer needed now that we switched to importlib
| "marshmallow>=3.0.0", | ||
| "microcosm>=4.0.0", | ||
| "microcosm-logging>=2.0.0", | ||
| "microcosm-logging>=2.1.0", |
There was a problem hiding this comment.
once this is merged and released this version will be available - should fix remaining test-failures in CI for this PR cc/ @salmanmashayekh @lfmoisa-globality
| "flake8-logging-format>=1.0.0", | ||
| "flake8-isort", | ||
| "flake8-logging-format>=1.0.0", | ||
| "flake8-print", |
Removing the deprecated
distutilsfrom the repo.