chore: setup lint and formatter with oxc#7
Open
SyahrulBhudiF wants to merge 2 commits intoglommer:mainfrom
Open
chore: setup lint and formatter with oxc#7SyahrulBhudiF wants to merge 2 commits intoglommer:mainfrom
SyahrulBhudiF wants to merge 2 commits intoglommer:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces code quality tooling and applies consistent formatting and linting across the codebase. It adds configuration files for formatting and linting, updates scripts and documentation for style consistency, and enhances the developer workflow with new npm scripts. The most important changes are grouped below:
Tooling and Configuration:
.oxfmtrc.jsonand.oxlintrc.jsonfiles to configure code formatting (oxfmt) and linting (oxlint) rules for the project. (.oxfmtrc.json,.oxlintrc.json) [1] [2]package.jsonto addoxfmtandoxlintas dev dependencies, and introduced new npm scripts for linting and formatting (lint,lint:fix,format,format:fix). (package.json) [1] [2]Code Style and Formatting:
scripts/bench-fts-configs.ts,scripts/bench-fts-slim.ts) to use consistent semicolons, trailing commas, and other style rules as specified in the new formatter config. [1] [2] [3]README.mdto match the new style guidelines (consistent semicolons and formatting).Documentation Improvements:
README.mdfor better readability and consistency. [1] [2] [3] [4] [5] [6]These changes collectively improve code consistency, enforce best practices, and streamline the development workflow.