Skip to content

IE10 opacity support #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jak wants to merge 4 commits into
base: master
Choose a base branch
from
Open

IE10 opacity support #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7358e7f
IE10 doesn't use alpha(opacity)
Oct 29, 2012
50241cf
More likely to work
Oct 29, 2012
9d132e7
Use feature detection rather than browser detection
Oct 29, 2012
1291c8a
Document changes and up version number
Oct 29, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
Glow Changelog

1.7.8

* glow.dom - Switched IE browser detection for feature detection so opacity works in IE 10

1.7.7

* glow.widgets.AutoSuggest - Fix bug that appeared when escaping the textfield after entering no text.
Expand Down
4 changes: 2 additions & 2 deletions build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
LINE=1.7
VERSION=1.7.7
CSSVERSION=177
VERSION=1.7.8
CSSVERSION=178
5 changes: 4 additions & 1 deletion src/dom/dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2845,7 +2845,10 @@
if (typeof val == "number" && hasUnits.test(originalProp)) {
val = val.toString() + "px";
}
if (prop == "opacity" && env.ie) {

// Use feature detection to support older IEs
// http://blogs.msdn.com/b/ie/archive/2010/08/17/ie9-opacity-and-alpha.aspx
if (prop == "opacity" && typeof document.createElement("div").style.opacity == 'undefined') {
//in IE the element needs hasLayout for opacity to work
thisStyle.zoom = "1";
if (val === "") {
Expand Down
4 changes: 4 additions & 0 deletions src/map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ gloader.map.add(
{
$version: "1.7.7"
}
,
{
$version: "1.7.8"
}
);

})(); // end closure
Expand Down