Create getter and setter for MarketplaceService.Stubbed#2
Conversation
migueleliasweb
force-pushed
the
workarond-marketplace-interface-stubbed
branch
from
8f1d144 to
bacddd1
Compare
| MarketplacePendingChange *MarketplacePendingChange `json:"marketplace_pending_change,omitempty"` | ||
| } | ||
|
|
||
| func (s *MarketplaceService) SetStubbed(stubbed bool) { |
There was a problem hiding this comment.
These two new methods need standard godoc-style comment strings.
There was a problem hiding this comment.
I don't know how I managed to miss this 😔
There was a problem hiding this comment.
Done, added the doc strings
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @migueleliasweb .
Sorry to be a pain, but please make the comments complete sentences per idiomatic Go style for the auto-generated godocs.
| MarketplacePendingChange *MarketplacePendingChange `json:"marketplace_pending_change,omitempty"` | ||
| } | ||
|
|
||
| // SetStubbed configures MarketplaceService Stubbed property |
There was a problem hiding this comment.
| // SetStubbed configures MarketplaceService Stubbed property | |
| // SetStubbed configures the MarketplaceService Stubbed property. |
There was a problem hiding this comment.
Sorry again to be a pain, but can you please add the ending periods in both cases as shown in the suggested changes?
| s.Stubbed = stubbed | ||
| } | ||
|
|
||
| // GetStubbed returns MarketplaceService Stubbed property |
There was a problem hiding this comment.
| // GetStubbed returns MarketplaceService Stubbed property | |
| // GetStubbed returns the MarketplaceService Stubbed property. |
migueleliasweb
force-pushed
the
workarond-marketplace-interface-stubbed
branch
2 times, most recently
from
5bc6f47 to
ce74d52
Compare
migueleliasweb
force-pushed
the
workarond-marketplace-interface-stubbed
branch
from
ce74d52 to
b201be0
Compare
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
LGTM, thank you, @migueleliasweb .
Merging.
2 participants
MarketplaceService.GetStubbedandMarketplaceService.SetStubbed