Conversation
It only had the State class, nothing else common
- Is silly to have private vars since this is not a library - Change the consumers dict to an object to make it easier to reference - No need to check for zombie processes, silly me - Clean up how the -o and -q cli switches filter data - Fix some overriding of top level import names
- Reformat with yapf - Structure so the processing can make use of tornado's concurrency features - Rename Consumer.configuration with Consumer.settings to more closely match Tornado's RequestHandler - Add Consumer.finish to explicitly end async processing - Add Consumer.require_setting to allow consumers to define the config/settings contract - Add Consumer.on_finish, Consumer.shutdown stubs - Add statsd incr/add_timing methods
- Extract counters to rejected.stats - Moved statsd support to rejected.statsd - Clean up error/failure counting behavior - Remove redundant methods like is_idle - Move private _variables to variables
Consumers can now work as a @gen.coroutine or normal sync process
gmr
added a commit
that referenced
this pull request
Apr 25, 2015
gmr
added a commit
that referenced
this pull request
Apr 1, 2026
Bounded pending deque (#2): Initialized with maxlen=qos_prefetch so memory usage is bounded by the configured prefetch count. RabbitMQ's QoS guarantee means the deque should never actually reach capacity in normal operation; the maxlen is a defensive backstop. Fix STATES class variable mutation (#3): Connection and Process were calling self.STATES[key] = value in __init__, which mutated the shared State base-class dict in-place — affecting all subclass instances. Each class now defines its own STATES as a class-level ClassVar that spreads the parent dict and adds its override, so each has an independent copy and __init__ no longer writes to shared state. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.