Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/app/models/spree/order_shipping.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def ship_shipment(shipment, external_number: nil, tracking_number: nil, suppress
# @return The carton created.
def ship(inventory_units:, stock_location:, address:, shipping_method:,
shipped_at: Time.current, external_number: nil, tracking_number: nil, suppress_mailer: false)

carton = nil

Spree::InventoryUnit.transaction do
Expand Down
4 changes: 2 additions & 2 deletions core/lib/spree/testing_support/extension_rake.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

desc "Generates a dummy app for testing an extension"
namespace :extension do
task :test_app, [:user_class] do |_t, _args|
task :test_app, [:user_class] do |_t, args|
Spree::DummyGeneratorHelper.inject_extension_requirements = true
Rake::Task['common:test_app'].invoke
Rake::Task['common:test_app'].invoke(args[:user_class])
end
end

This file was deleted.

9 changes: 9 additions & 0 deletions legacy_promotions/app/models/spree/promotion_code_batch.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,14 @@ class CantProcessStartedBatch < StandardError
def finished?
state == "completed"
end

def process
if state == "pending"
update!(state: "processing")
PromotionCodeBatchJob.perform_later(self)
else
raise CantProcessStartedBatch.new("Batch #{id} already started")
end
end
end
end