Skip to content

Fixed a few things and updated enet#1

Open
bjorn wants to merge 4 commits intognu-lorien:masterfrom
bjorn:master
Open

Fixed a few things and updated enet#1
bjorn wants to merge 4 commits intognu-lorien:masterfrom
bjorn:master

Conversation

@bjorn
Copy link
Copy Markdown
Contributor

@bjorn bjorn commented Mar 26, 2011

Hey Andrew,

I noticed you had moved crack-attack to github. :-)

I needed to make a few fixes before it would compile for me, and I decided to update enet to 1.3.1, since 1.0 is no longer maintained. This breaks compatiblity, however Lee has said that he doesn't expect to break compatibility again.

I didn't keep the ChangeLog updated, since I thought the git log was enough. If you'd still like that file updated then I'll update my commits.

Best regards,
Bjørn

bjorn added 4 commits March 26, 2011 23:16
* Two files needed to include cstdio for functions such as snprintf,
  fopen and sscanf.

* If ENABLE_BINRELOC is not defined, GC_MODEL_DIRECTORY can only handle
  plain string literals, not char * variables. Changed the code in
  obj_block.cxx accordingly.
This breaks compatibility with clients that are still using enet 1.0.

The fixes for datatype size on amd64 have be reapplied.
(77140d6)
Superfluous semicolon and a const char* being used as a char*. Adding a
cast avoided the warning.
@gnu-lorien
Copy link
Copy Markdown
Owner

On Sat, Mar 26, 2011 at 7:04 PM, bjorn
reply@reply.github.com
wrote:

Hey Andrew,

I noticed you had moved crack-attack to github. :-)

I needed to make a few fixes before it would compile for me, and I decided to update enet to 1.3.1, since 1.0 is no longer maintained. This breaks compatiblity, however Lee has said that he doesn't expect to break compatibility again.

I didn't keep the ChangeLog updated, since I thought the git log was enough. If you'd still like that file updated then I'll update my commits.

As you might be able to tell, I haven't had much time lately for real
maintainer duties on crack-attack. I won't be able to get to this
until sometime next week.

If you're interested in the job I'm willing to transfer control of the

resources I have to you.

Andrew Sayman
Jabber: gnu_lorien@jabber.org

@bjorn
Copy link
Copy Markdown
Contributor Author

bjorn commented Mar 30, 2011

As you might be able to tell, I haven't had much time lately for real
maintainer duties on crack-attack. I won't be able to get to this
until sometime next week.

Ha, you tell that to a contributor who has been out for almost 5
years? I'm not in a rush so no problem there. :-)

It's already nice to hear you're still there!

If you're interested in the job I'm willing to transfer control of the
resources I have to you.

Nah, rather a slow maintainer than a non-maintainer, that I would
probably be. I'm trying to work on too many projects at the same time
already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants