Fix NSData initWithBytesNoCopy:length:deallocator:#213
Merged
Conversation
The previous implementation simply swizzled `NSData` into `NSDataWithDeallocatorBlock`, and forgot to actually assign `bytes` and `length`.
madsmtm
added a commit
to madsmtm/objc2
that referenced
this pull request
Oct 29, 2021
NSData::from_vec is broken in GNUStep, see gnustep/libs-base#213
madsmtm
added a commit
to madsmtm/objc2
that referenced
this pull request
Oct 29, 2021
NSData initWithBytesNoCopy:length:deallocator: is broken in GNUStep, see gnustep/libs-base#213
madsmtm
added a commit
to madsmtm/objc2
that referenced
this pull request
Oct 29, 2021
NSData initWithBytesNoCopy:length:deallocator: is broken in GNUStep, see gnustep/libs-base#213
fredkiefer
approved these changes
Oct 29, 2021
Member
fredkiefer
left a comment
fredkiefer
left a comment
There was a problem hiding this comment.
As always it would be great to add a test for the bug you are fixing here. That would prevent the same bug from occurring again in the future.
Specifically on initWithBytesNoCopy:length:deallocator:
Contributor
Author
|
Alright, I think I did that (at least this test case is how I discovered the bug myself), but I'm open for suggestions, I'm not very experienced in your codebase. |
Contributor
Author
|
Cool, thanks for the super quick response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation simply swizzled
NSDataintoNSDataWithDeallocatorBlock, and forgot to actually assignbytesandlength.NSMutableDatadoes not have this problem.An alternative would be to call
NSDataWithDeallocatorBlock'sinitWithBytesNoCopy:length:deallocator:at this point, I don't know which is better.