Skip to content

Enable uri based mongo connection string to allow complete config #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prabhjot-Sethi merged 1 commit into from
Jul 14, 2025
Merged

Enable uri based mongo connection string to allow complete config #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions db/mongo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,19 +329,26 @@ type mongoClient struct {
type MongoConfig struct {
Host string
Port string
Uri string
Username string
Password string
}

func (c *MongoConfig) validate() error {
if c.Host == "" {
c.Host = "localhost"
}
if c.Port == "" || c.Port == "0" {
c.Port = "27017"
if c.Uri != "" {
if c.Host != "" || c.Port != "" {
return errors.Wrap(errors.InvalidArgument, "cannot provide host and port if uri is configured")
}
} else {
if _, err := strconv.Atoi(c.Port); err != nil {
return errors.Wrap(errors.InvalidArgument, "invalid database port")
if c.Host == "" {
c.Host = "localhost"
}
if c.Port == "" || c.Port == "0" {
c.Port = "27017"
} else {
if _, err := strconv.Atoi(c.Port); err != nil {
return errors.Wrap(errors.InvalidArgument, "invalid database port")
}
}
}
return nil
Expand All @@ -351,7 +358,14 @@ func NewMongoClient(conf *MongoConfig) (StoreClient, error) {
if err := conf.validate(); err != nil {
return nil, err
}
uri := "mongodb://" + net.JoinHostPort(conf.Host, conf.Port)
// TODO(prabhjot) better to enventually switch to just uri
// instead of allowing host port configuration
var uri string
if conf.Uri != "" {
uri = conf.Uri
} else {
uri = "mongodb://" + net.JoinHostPort(conf.Host, conf.Port)
}
clientOptions := options.Client()
clientOptions.ApplyURI(uri)
clientOptions.SetAuth(options.Credential{
Expand Down