Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions error_translator.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package postgres

import (
"encoding/json"
"fmt"

"gorm.io/gorm"

Expand All @@ -27,7 +28,7 @@ type ErrMessage struct {
func (dialector Dialector) Translate(err error) error {
if pgErr, ok := err.(*pgconn.PgError); ok {
if translatedErr, found := errCodes[pgErr.Code]; found {
return translatedErr
return fmt.Errorf("%w: %w", translatedErr, pgErr)
}
return err
}
Expand All @@ -44,7 +45,7 @@ func (dialector Dialector) Translate(err error) error {
}

if translatedErr, found := errCodes[errMsg.Code]; found {
return translatedErr
return fmt.Errorf("%w: %s", translatedErr, errMsg.Message)
}
return err
}
56 changes: 56 additions & 0 deletions error_translator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,3 +53,59 @@ func TestDialector_Translate(t *testing.T) {
})
}
}

func TestDialector_Translate_PreservesOriginalError(t *testing.T) {
tests := []struct {
name string
pgErr *pgconn.PgError
wantGormErr error
}{
{
name: "it should preserve original pgError detail on ErrDuplicatedKey",
pgErr: &pgconn.PgError{
Code: "23505",
Message: "duplicate key value violates unique constraint",
Detail: "Key (email)=(foo@bar.com) already exists.",
ConstraintName: "users_email_key",
},
wantGormErr: gorm.ErrDuplicatedKey,
},
{
name: "it should preserve original pgError detail on ErrForeignKeyViolated",
pgErr: &pgconn.PgError{
Code: "23503",
Message: "insert or update on table violates foreign key constraint",
Detail: "Key (user_id)=(999) is not present in table \"users\".",
ConstraintName: "orders_user_id_fkey",
},
wantGormErr: gorm.ErrForeignKeyViolated,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
dialector := Dialector{}
err := dialector.Translate(tt.pgErr)

// errors.Is() must still work after wrapping
if !errors.Is(err, tt.wantGormErr) {
t.Errorf("errors.Is() expected %v, got %v", tt.wantGormErr, err)
}

// errors.As() must be able to unwrap original pgErr
var pgErr *pgconn.PgError
if !errors.As(err, &pgErr) {
t.Errorf("errors.As() failed: original *pgconn.PgError is not accessible")
return
}

// original detail must be preserved
if pgErr.Detail != tt.pgErr.Detail {
t.Errorf("Detail expected %q, got %q", tt.pgErr.Detail, pgErr.Detail)
}
if pgErr.ConstraintName != tt.pgErr.ConstraintName {
t.Errorf("ConstraintName expected %q, got %q", tt.pgErr.ConstraintName, pgErr.ConstraintName)
}
})
}
}
Loading