use the new log package in examples#34
Merged
peterbourgon merged 1 commit intosourcefrom Mar 26, 2022
Merged
Conversation
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Member
|
Not sure we want to do this just yet. The log package was extracted for people who use it in exclusion from the rest of the kit repo. At least for now, I don't intend for anything in the kit repo to use it. Is that a dumb idea? Maybe. Tell me if it is. |
Member
|
I think the right time to do is in tandem with a release containing the changes in go-kit/kit#1173. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Sagi-Kazar mark.sagikazar@gmail.com